Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue title rendering and refactor legacy function names #32703

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix issue title rendering and refactor legacy function names #32703

merged 1 commit into from
Dec 4, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 4, 2024 •
edited
Loading

Fix #32700, regression of recent markup refactoring

And by the way, clarify many legacy problems:

  1. Some "RenderXxx" functions do not really "render", they only call "post processors"
  2. Merge "RenderEmoji | RenderCodeBlock", they are all for "simple issue title"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 4, 2024
Closed
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Dec 4, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 4, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2024
@wxiaoguang wxiaoguang changed the title Fix issue title rendering Fix issue title rendering and refactor legacy function names Dec 4, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 4, 2024 01:23
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 4, 2024
@wxiaoguang wxiaoguang merged commit 2f43536 into go-gitea:main Dec 4, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-markup-link branch December 4, 2024 01:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c87deba 
* giteaofficial/main:
  Fix delete branch perm checking (go-gitea#32654)
  Refactor markdown editor and use it for milestone description editor (go-gitea#32688)
  Fix issue title rendering and refactor legacy function names (go-gitea#32703)
  Fix oauth2 login methods (go-gitea#32698)
  Fix word overflow in file search page (go-gitea#32695)
  Add Swift login endpoint (go-gitea#32693)
  Quick fix for license file name (go-gitea#32696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Issue number no longer clickable in pr title
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot