Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_archived option for issue indexer #32735

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 6, 2024

Try to fix #32697

Reason:
is_archived is already defined in the query options, but it is not implemented in the indexer.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2024
@yp05327 yp05327 requested a review from wolfogre December 6, 2024 04:11
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 6, 2024
@lunny
Copy link
Member

lunny commented Dec 6, 2024

The indexes need to be updated once a repository changes from/to archived.

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the PR WIP?
LGTM otherwise.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 6, 2024

I only tested the DB indexer manually. Others are not tested manually.

@lunny
Copy link
Member

lunny commented Dec 6, 2024

unarchived should also trigger the index rebuilding.

@yp05327 yp05327 marked this pull request as ready for review December 8, 2024 23:31
@yp05327 yp05327 requested a review from lunny December 8, 2024 23:32
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2024
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index will be used both in global search and repository search. In the archived repository, it should be searched. But from a global issue search, the issues in the archived repositories should not be displayed.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Dec 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2024
@lunny lunny added this to the 1.23.0 milestone Dec 11, 2024
@lunny lunny merged commit d43620e into go-gitea:main Dec 11, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2024
* giteaofficial/main:
  Switch to `eslint-plugin-import-x` (go-gitea#32790)
  Fix clone panel js error (go-gitea#32798)
  [skip ci] Updated translations via Crowdin
  Add `is_archived` option for issue indexer (go-gitea#32735)
  Upgrade dependency crypto library (go-gitea#32750)
  Add standard-compliant route to serve outdated R packages (go-gitea#32783)
  Fix repo home file list (go-gitea#32788)
  Rearrange Clone Panel (go-gitea#31142)
  Fix a number of typescript errors (go-gitea#32773)
  Add label/author/assignee filters to the user/org home issue list (go-gitea#32779)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
@yp05327 yp05327 deleted the add-is_archived-in-issue-index branch January 17, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Requests view shows PRs in archived repos
5 participants