Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some LDAP code #32849

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Refactor some LDAP code #32849

merged 2 commits into from
Dec 15, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 15, 2024 •
edited
Loading

This PR was written to test #32844, everything passes, so it is a pure refactoring PR now.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2024
@wxiaoguang wxiaoguang marked this pull request as draft December 15, 2024 06:14
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 15, 2024
@wxiaoguang wxiaoguang changed the title Fix LDAP Refactor some LDAP code Dec 15, 2024
@wxiaoguang wxiaoguang marked this pull request as ready for review December 15, 2024 06:59
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 15, 2024
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 15, 2024 11:38
@wxiaoguang wxiaoguang merged commit b01b0b9 into go-gitea:main Dec 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 15, 2024
@wxiaoguang wxiaoguang deleted the fix-ldap branch December 15, 2024 12:06
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot