Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tenv and testifylint rules #32852

Merged
merged 4 commits into from
Dec 15, 2024
Merged

Enable tenv and testifylint rules #32852

merged 4 commits into from
Dec 15, 2024

Conversation

TheFox0x7
Copy link
Contributor

Enables tenv and testifylint linters
closes: #32842

@TheFox0x7
enable tenv rule
69f8729
@TheFox0x7
enable testifylint rule
f1d3eb1 
excluded go-require because it is troublesome to resolve properly and
require-error because it makes the change massive
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2024
@silverwind silverwind self-requested a review December 15, 2024 08:30
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2024
silverwind
silverwind approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it passes

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 15, 2024 10:16
@wxiaoguang wxiaoguang added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. type/testing labels Dec 15, 2024
@wxiaoguang wxiaoguang merged commit 33e8e82 into go-gitea:main Dec 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2024
@TheFox0x7 TheFox0x7 deleted the enable-testifylint branch December 15, 2024 10:42
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/internal modifies/migrations size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Enable testifylint and tenv linters in golangci-lint
5 participants
@TheFox0x7 @silverwind @wxiaoguang @lunny @GiteaBot