Update go tool dependencies #32916
Merged
Update go tool dependencies #32916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
backport/v1.23
pull-request-size
bot
added
size/S
github-actions
bot
added
modifies/go
|
Issues were confirmed on CI and I fixed them. The only interesting one is this one where the removed code was dead code because the same condtion was checked earlier. |
|
Actually, no backport needed as per ulikunitz/xz@4f11dce. |
lunny
approved these changes
Dec 19, 2024
GiteaBot
added
lgtm/need 1
kemzeb
approved these changes
Dec 19, 2024
GiteaBot
added
lgtm/done
|
To resolve #33349, I think we need to backport this one. |
|
Sure, let's see if it's automatic. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jan 22, 2025
Update all go tool dependencies to latest version. WIP because I think there are new gopls errors, would like to confirm them on CI first. Here is from a local run: ``` modules/markup/markdown/goldmark.go:115:37-53: unnecessary type arguments modules/markup/html.go:45:32-49: unnecessary type arguments modules/markup/internal/renderinternal.go:20:33-49: unnecessary type arguments modules/markup/common/linkify.go:27:32-49: unnecessary type arguments modules/util/time_str.go:28:39-63: unnecessary type arguments routers/web/repo/pull.go:704:19: impossible condition: non-nil == nil modules/util/util_test.go:248:14-23: unused parameter: other ``` ~~Backport because the `gxz` update might have security benefits.~~
|
Manual backport: #33355 |
techknowlogick
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all go tool dependencies to latest version. WIP because I think there are new gopls errors, would like to confirm them on CI first. Here is from a local run:
Backport because thegxzupdate might have security benefits.