Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings not being loaded at CLI (#26402) #33048

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix settings not being loaded at CLI (#26402) #33048

merged 2 commits into from
Dec 30, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #26402 by @cassiozareck

Closes #25898
The problem was that the default settings weren't being loaded, so

gitea/models/user/user.go

Line 593 in ad69f71

u.AllowCreateOrganization = setting.Service.DefaultAllowCreateOrganization && !setting.Admin.DisableRegularOrgCreation

was always false.

@cassiozareck @lunny
@wxiaoguang @GiteaBot
Fix settings not being loaded at CLI (go-gitea#26402)
9143439 
Closes go-gitea#25898
The problem was that the default settings weren't being loaded

---------

Signed-off-by: cassiozareck <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug labels Dec 30, 2024
@GiteaBot GiteaBot requested review from lunny and wxiaoguang December 30, 2024 06:30
@GiteaBot GiteaBot added this to the 1.23.0 milestone Dec 30, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 30, 2024 06:48
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2024
@wxiaoguang wxiaoguang merged commit 27de603 into go-gitea:release/v1.23 Dec 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @wxiaoguang @cassiozareck