Refactor legacy line-number and scroll code #33094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wxiaoguang
force-pushed
the
refactor-line-scroll
branch
from
c64d476 to
6bc2439
Compare
wxiaoguang
force-pushed
the
refactor-line-scroll
branch
from
6bc2439 to
cfe33b6
Compare
lunny
approved these changes
Jan 3, 2025
GiteaBot
added
lgtm/need 1
metiftikci
reviewed
Jan 3, 2025
web_src/css/base.css
Outdated
| @@ -693,6 +693,7 @@ input:-webkit-autofill:active, | |||
|
|
|||
| .ui.dropdown .menu > .header { | |||
| font-size: 0.8em; | |||
| text-transform: none; /* reset fomantic's "uppercase" */ | |||
There was a problem hiding this comment.
Sure, we have fixed all "uppercase" headers in history, modern UI doesn't use uppercase.
This is the last one.
There was a problem hiding this comment.
| // set scrollRestoration to 'manual' when there is a hash in url, so that the scroll position will not be remembered after refreshing | ||
| if (window.history.scrollRestoration !== 'manual') window.history.scrollRestoration = 'manual'; | ||
| // wait for a while because some elements (eg: image, editor, etc.) may change the viewport's height. | ||
| setTimeout(() => commentDiv.scrollIntoView({block: 'start'}), 100); |
There was a problem hiding this comment.
I have tested, "center" is not good enough. For example, when the comment is quite long.
| } | ||
| }; | ||
| onHashChange(); | ||
| window.addEventListener('hashchange', onHashChange); |
There was a problem hiding this comment.
just to inform, history.pushState does not fire hashchange event, so not sure if this listener does something
There was a problem hiding this comment.
It is the case when user manually change the URL, eg:
/file#L1 => /file#L1-L3
And that's the old logic, I think it is good to keep it
| if (first) { | ||
| // set scrollRestoration to 'manual' when there is a hash in url, so that the scroll position will not be remembered after refreshing | ||
| if (window.history.scrollRestoration !== 'manual') window.history.scrollRestoration = 'manual'; | ||
| first.scrollIntoView({block: 'start'}); |
There was a problem hiding this comment.
same here. maybe center better?
There was a problem hiding this comment.
According to my test, I think "start" is better.
delvh
approved these changes
Jan 3, 2025
GiteaBot
added
lgtm/done
lafriks
pushed a commit
that referenced
this pull request
Jan 3, 2025
wxiaoguang
force-pushed
the
refactor-line-scroll
branch
from
5f7018d to
31e9deb
Compare
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 6, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix dropdown menu header and mobile view (go-gitea#33108) workflow_dispatch use workflow from trigger branch (go-gitea#33098) [skip ci] Updated translations via Crowdin Trivial fixes (go-gitea#33103) Fix empty git repo handling logic (go-gitea#33101) Refactor legacy line-number and scroll code (go-gitea#33094) Use `Project-URL` metadata field to get a PyPI package's homepage URL (go-gitea#33089) Clean up legacy form CSS styles (go-gitea#33081) [skip ci] Updated translations via Crowdin add myself to maintainers (go-gitea#33088) Make Gitea always use its internal config, ignore `/etc/gitconfig` (go-gitea#33076) Fix "stop time tracking button" on navbar (go-gitea#33084) Fix bleve fuzziness search (go-gitea#33078) Try to fix ACME directory problem (go-gitea#33072) Refactor env var related code (go-gitea#33075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now 7 "import jquery" files left.
Some fixes could be backport to 1.23 (not blocking the release)