Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing transaction when set merge #33113

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Add missing transaction when set merge #33113

merged 4 commits into from
Jan 6, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 6, 2025 •
edited
Loading

backport from #33079

SetMerged should be in a database transaction otherwise it's possible to have dirty data.

@GiteaBot GiteaBot added this to the 1.23.0 milestone Jan 6, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 6, 2025
@lunny lunny added type/bug and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. modifies/go Pull requests that update Go code labels Jan 6, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 6, 2025
@lunny lunny enabled auto-merge (squash) January 6, 2025 17:54
@lunny lunny merged commit 9899989 into go-gitea:release/v1.23 Jan 6, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 6, 2025
@lunny lunny deleted the lunny/transaction_setmerge branch January 8, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @Zettat123 @GiteaBot