Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated path to s6-svscan after alpine upgrade #33185

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Use updated path to s6-svscan after alpine upgrade #33185

merged 2 commits into from
Jan 10, 2025

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jan 9, 2025 •
edited by lunny
Loading

Fix #33163

@techknowlogick techknowlogick added issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile backport/v1.23 This PR should be backported to Gitea 1.23 labels Jan 9, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@techknowlogick techknowlogick requested a review from lunny January 9, 2025 19:52
@techknowlogick techknowlogick mentioned this pull request Jan 9, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2025
@yp05327 yp05327 changed the title use updated path to s6-svscan after alpine upgrade Use updated path to s6-svscan after alpine upgrade Jan 10, 2025
@wxiaoguang wxiaoguang merged commit 189e740 into go-gitea:main Jan 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 10, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 10, 2025
@techknowlogick @wxiaoguang @GiteaBot
Use updated path to s6-svscan after alpine upgrade (go-gitea#33185)
daa9698 
Fix go-gitea#33163

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Jan 10, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 10, 2025
lunny pushed a commit that referenced this pull request Jan 10, 2025
@GiteaBot @techknowlogick @wxiaoguang
Use updated path to s6-svscan after alpine upgrade (#33185) (#33188)
940a930 
Backport #33185 by @techknowlogick

Fix #33163

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@techknowlogick techknowlogick deleted the s6switch branch January 10, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

"/usr/bin/entrypoint: exec: line 40: /bin/s6-svscan: not found" on gitea/gitea:1.23.0 docker
5 participants
@techknowlogick @lunny @yp05327 @wxiaoguang @GiteaBot