Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor markdown not incrementing in a numbered list (#33187) #33193

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix editor markdown not incrementing in a numbered list (#33187) #33193

merged 1 commit into from
Jan 10, 2025

Conversation

wxiaoguang
Copy link
Contributor

Backport #33187 (no conflict)

@harryvince @wxiaoguang
Fix editor markdown not incrementing in a numbered list (go-gitea#33187)
e6d2d85 
Amended the logic for newPrefix in the MarkdownEditor to resolve
incorrect number ordering.

Fixes go-gitea#33184

Attached screenshot of fixed input similar to issue 
<img width="175" alt="Screenshot 2025-01-09 at 23 59 24"
src="https://github.com/user-attachments/assets/dfa23cf1-f3db-4b5e-99d2-a71bbcb289a8"
/>

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added this to the 1.23.1 milestone Jan 10, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2025
@lunny lunny merged commit 1454e1b into go-gitea:release/v1.23 Jan 10, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the backport-markdown-list branch January 10, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.1
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot @harryvince