Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor context repository #33202

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Refactor context repository #33202

merged 4 commits into from
Jan 12, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 10, 2025 •
edited
Loading

  1. rename BranchNameSubURL to RefTypeNameSubURL and add comments
    • it is not for "branch" but for all "ref" types
  2. remove unnecessary/unused methods & variables.
    • FileExists: never used
    • ctx.Data["Username"]: never used
    • ctx.Data["RepoRelPath"]: never used
    • ctx.Data["IsRepositoryOwner"]: never used
    • ctx.Data["IsRepositoryAdmin"]: replaced by Permission.IsAdmin
    • ctx.Data["RepoOwnerIsOrganization"]: replaced by Repository.Owner.IsOrganization
    • IsUserRepoAdmin: never used
    • IsUserRepoWriter: replaced by ctx.Repo.CanWrite
  3. ignore useless SetEditorconfigIfExists err

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/33202/files?diff=unified&w=1

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 10, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 10, 2025
Open
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 10, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 12, 2025 03:15
@wxiaoguang wxiaoguang merged commit a068462 into go-gitea:main Jan 12, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 12, 2025
@wxiaoguang wxiaoguang deleted the refactor-repo-tmpl branch January 12, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot