Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Account linking page (#33325) #33327

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Jan 19, 2025

Backport #33325 by CrimsonEdgeHope

Fix password form missing whilst linking account even with ENABLE_PASSWORD_SIGNIN_FORM = true.

Remove redundant empty box in account linking sign up page when LinkAccountMode is true.

Fix password form missing whilst linking account even with
`ENABLE_PASSWORD_SIGNIN_FORM = true`.

Remove redundant empty box in account linking sign up page when
`LinkAccountMode` is true.

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug labels Jan 19, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2025
@GiteaBot GiteaBot added this to the 1.23.2 milestone Jan 19, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 19, 2025 12:38
@wxiaoguang wxiaoguang merged commit e72d001 into go-gitea:release/v1.23 Jan 19, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants