Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system admin cannot fork or get private fork with API #33401

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Fix system admin cannot fork or get private fork with API #33401

merged 5 commits into from
Jan 27, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 26, 2025

Fix #33368

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 backport/v1.23 This PR should be backported to Gitea 1.23 labels Jan 26, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 26, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 26, 2025
Zettat123
Zettat123 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@Zettat123 Zettat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed. Otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@lunny lunny enabled auto-merge (squash) January 27, 2025 15:59
@lunny lunny merged commit 77d14fb into go-gitea:main Jan 27, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 27, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 27, 2025
@lunny @GiteaBot
Fix system admin cannot fork or get private fork with API (go-gitea#3…
060d4ed 
…3401)

Fix go-gitea#33368
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@GiteaBot GiteaBot mentioned this pull request Jan 27, 2025
Merged
@lunny lunny deleted the lunny/fix_get_fork branch January 27, 2025 17:55
silverwind pushed a commit that referenced this pull request Jan 27, 2025
@GiteaBot @lunny
Fix system admin cannot fork or get private fork with API (#33401) (#…
b6fd874 
…33417)

Backport #33401 by @lunny

Fix #33368

Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny added the backport/done All backports for this PR have been created label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Regression: Admin users cannot see private forks
4 participants
@lunny @silverwind @Zettat123 @GiteaBot