Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert empty lfs ref name #33454

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Revert empty lfs ref name #33454

merged 1 commit into from
Jan 31, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33453

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 31, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 31, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 31, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 31, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2025
delvh
delvh approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the optimal approach be to set a valid ref name?
But yeah, I can accept this as it is for now.

@wxiaoguang
Copy link
Contributor Author

Wouldn't the optimal approach be to set a valid ref name?

Because of this: #32838 (comment)

@wxiaoguang wxiaoguang merged commit 4f3cc26 into go-gitea:main Jan 31, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-lfs-ref branch January 31, 2025 10:03
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 31, 2025
@wxiaoguang @GiteaBot
Revert empty lfs ref name (go-gitea#33454)
761e788 
Fix go-gitea#33453
@GiteaBot GiteaBot mentioned this pull request Jan 31, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 31, 2025
wxiaoguang added a commit that referenced this pull request Jan 31, 2025
@GiteaBot @wxiaoguang
Revert empty lfs ref name (#33454) (#33457)
159544a 
Backport #33454 by wxiaoguang

Fix #33453

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 3, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6462e8f 
* giteaofficial/main: (53 commits)
  [skip ci] Updated licenses and gitignores
  Correct bot label `vertical-align` (go-gitea#33477)
  chore: fix some trivial problems and TODOs (go-gitea#33473)
  Worktime tracking for the organization level (go-gitea#19808)
  Skip deletion error for action artifacts (go-gitea#33476)
  Update .changelog file to add performance label group (go-gitea#33472)
  actions view: move loading of task attributes etc... into own func (go-gitea#31494)
  [skip ci] Updated translations via Crowdin
  Update feishu icon (go-gitea#33470)
  Inclusion of rename organization api (go-gitea#33303)
  [skip ci] Updated translations via Crowdin
  Hide/disable unusable UI elements when a repository is archived (go-gitea#33459)
  Fix SSH LFS memory usage (go-gitea#33455)
  Revert empty lfs ref name (go-gitea#33454)
  Update `@github/text-expander-element`, adapt type imports (go-gitea#33449)
  Support choose email when creating a commit via web UI (more) (go-gitea#33445)
  Fix issue sidebar dropdown keyboard support (go-gitea#33447)
  Fix "redirect link" handling (go-gitea#33440)
  Refactor repository transfer (go-gitea#33211)
  Enable two more strict options in tsconfig (go-gitea#33438)
  ...
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Feb 4, 2025
@wxiaoguang @earl-warren
Revert empty lfs ref name (go-gitea#33454)
f44f3cb 
Fix go-gitea#33453

(cherry picked from commit 4f3cc26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Unable to migrrate repos from Hugging Face
5 participants
@wxiaoguang @lunny @lafriks @delvh @GiteaBot