Add tzdata to Windows binary releases (#33463) #33503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timetzdata` is already used in the docker images, this includes them for the binary release files too. Related to go-gitea#33235 (I don't have a windows machine setup to test this though) --------- Co-authored-by: wxiaoguang <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
approved these changes
Feb 5, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
changed the title
timetzdata build tag to binary releases (#33463)
wxiaoguang
changed the title
hiifong
approved these changes
Feb 5, 2025
GiteaBot
added
lgtm/done
lunny
added a commit
that referenced
this pull request
Feb 5, 2025
Wait - #33499 - #33493 - #33503 --------- Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #33463
timetzdatais already used in the docker images, this includes them for the binary release files too.Related to #33235 (I don't have a windows machine setup to test this though)