add spacing between sign in button's icon and text #33609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
pull-request-size
bot
added
the
size/XS
|
Would it be possible for you to share some screenshots, if that's convenient for you? |
wxiaoguang
reviewed
Feb 16, 2025
|
No problem. Below are screenshots of the home page in 1080p before and after the change. Note that I've modified my home page to be simpler and removed the "Help" link from the navbar. These changes are not included in the pull request, just focus on the sign in button at the top left.
|
wxiaoguang
approved these changes
Feb 16, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Feb 16, 2025
GiteaBot
added
lgtm/done
techknowlogick
added
type/enhancement
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 17, 2025
* giteaofficial/main: Add API to support link package to repository and unlink it (go-gitea#33481) [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#33587) [chore] add git mailmap for proper attribution of authorship (go-gitea#33612) Move commits signature and verify functions to service layers (go-gitea#33605) add spacing between sign in button's icon and text (go-gitea#33609) enable literal string for code search (go-gitea#33590) [skip ci] Updated translations via Crowdin Artifacts download api for artifact actions v4 (go-gitea#33510) Fix bug when get commit (go-gitea#33602) Fix mirror bug (go-gitea#33597) Fix typo in HTML attribute (go-gitea#33599) Use default Git timeout when checking repo health (go-gitea#33593) Improve commits list performance to reduce unnecessary database queries (go-gitea#33528) Performance optimization for pull request files loading comments attachments (go-gitea#33585) Fix PR's target branch dropdown (go-gitea#33589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request edits the head_navbar template and adds spacing between the icon and the text inside the sign in button of the navbar (button which displays at the top right of Gitea's pages when the user is not signed in).
It bugged me that there was no spacing between the button's contents so I test ran this change quickly on my server and thought it looked a lot better, so decided to make this pull request. Up to you to decide if you agree that it looks better :)