Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR web route permission check #33636

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Fix PR web route permission check #33636

merged 4 commits into from
Feb 19, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 18, 2025 •
edited
Loading

See the FIXME comment in code. Otherwise, if a repo's issue unit is disabled, then the PRs can't be edited anymore.

By the way, make the permission log output look slightly better.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 18, 2025
@wxiaoguang wxiaoguang added type/bug and removed modifies/go Pull requests that update Go code labels Feb 18, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 18, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 18, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Feb 18, 2025
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2025
metiftikci
metiftikci reviewed Feb 18, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2025
@lunny @metiftikci
Update routers/web/web.go
b89a961 
Co-authored-by: metiftikci <[email protected]>
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2025
@lunny lunny enabled auto-merge (squash) February 19, 2025 00:44
@lunny lunny merged commit c2e23d3 into go-gitea:main Feb 19, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bc278d7 
* giteaofficial/main:
  Fix PR web route permission check (go-gitea#33636)
  fix: add missing locale (go-gitea#33641)
  Fix Untranslated Text on Actions Page (go-gitea#33635)
  Improve button layout on small screens (go-gitea#33633)
  Update README screenshots (go-gitea#33347)
@wxiaoguang wxiaoguang deleted the fix-pr-perm branch February 19, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@metiftikci metiftikci metiftikci approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @metiftikci @GiteaBot