Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GiteaServer as the user agent for http requests #3404

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Use GiteaServer as the user agent for http requests #3404

merged 1 commit into from
Jan 22, 2018

Conversation

strk
Copy link
Member

@strk strk commented Jan 22, 2018

Otherwise we're still presenting ourselves as GogsServer...

@strk
Use GiteaServer as the user agent for http requests
fd0bae1 
Otherwise we're still presenting ourselves as GogsServer...
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1ce3572). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3404   +/-   ##
=========================================
  Coverage          ?   35.62%           
=========================================
  Files             ?      281           
  Lines             ?    40552           
  Branches          ?        0           
=========================================
  Hits              ?    14445           
  Misses            ?    23972           
  Partials          ?     2135
Impacted Files Coverage Δ
modules/httplib/httplib.go 24.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce3572...fd0bae1. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 22, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2018
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 22, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 22, 2018
@lafriks lafriks merged commit 00d0847 into go-gitea:master Jan 22, 2018
@strk strk deleted the gitea-useragent branch January 29, 2018 10:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@strk @codecov-io @thehowl @lafriks @tboerger