Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sensitive headers #3429

Merged
merged 5 commits into from
Jan 30, 2018
Merged

Add sensitive headers #3429

merged 5 commits into from
Jan 30, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 29, 2018 •
edited
Loading

Fix #3304

@strk
Copy link
Member

strk commented Jan 29, 2018

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 29, 2018
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 29, 2018
@sapk sapk changed the title [WIP] Add sensitive headers Add sensitive headers Jan 29, 2018
@sapk
Copy link
Member Author

sapk commented Jan 29, 2018

I got visual confirmation. ^^
image

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2018
@appleboy
Copy link
Member

build error?

modules/httplib/httplib.go:169: cannot use value (type string) as type []string in assignment

@sapk
Copy link
Member Author

sapk commented Jan 30, 2018

CI must have build 68abea5 and not 6d591db

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d09704e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3429   +/-   ##
=========================================
  Coverage          ?   35.57%           
=========================================
  Files             ?      281           
  Lines             ?    40586           
  Branches          ?        0           
=========================================
  Hits              ?    14439           
  Misses            ?    24009           
  Partials          ?     2138
Impacted Files Coverage Δ
models/webhook.go 67.02% <100%> (ø)
modules/httplib/httplib.go 25.44% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09704e...f02e270. Read the comment docs.

@lafriks lafriks added this to the 1.4.0 milestone Jan 30, 2018
@lafriks lafriks merged commit b3fd94c into go-gitea:master Jan 30, 2018
@sapk sapk deleted the add-sensitive-headers branch May 19, 2018 23:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Webhooks post X-Github-* should be X-GitHub-*
6 participants
@sapk @strk @appleboy @codecov-io @tboerger @lafriks