Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markbates/goth library #3533

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Update markbates/goth library #3533

merged 3 commits into from
Feb 19, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Feb 18, 2018

Fixes #3437

@lafriks
Update markbates/goth library
2a4a49d 
Signed-off-by: Lauris Bukšis-Haberkorns <[email protected]>
@lafriks lafriks added this to the 1.5.0 milestone Feb 18, 2018
@codecov-io
Copy link

codecov-io commented Feb 18, 2018 •
edited
Loading

Codecov Report

Merging #3533 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3533      +/-   ##
==========================================
+ Coverage   35.74%   35.75%   +<.01%     
==========================================
  Files         284      284              
  Lines       40773    40773              
==========================================
+ Hits        14575    14577       +2     
+ Misses      24039    24037       -2     
  Partials     2159     2159
Impacted Files Coverage Δ
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f75140...80da589. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2018
@lunny
Copy link
Member

lunny commented Feb 19, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2018
@lafriks lafriks merged commit 7b29780 into go-gitea:master Feb 19, 2018
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Feb 19, 2018
@lafriks
Update markbates/goth library (go-gitea#3533)
fde3efa 
Signed-off-by: Lauris Bukšis-Haberkorns <[email protected]>
@lafriks lafriks deleted the fix/update_goth branch February 19, 2018 11:44
@lafriks lafriks mentioned this pull request Feb 19, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 19, 2018
appleboy pushed a commit that referenced this pull request Feb 19, 2018
@lafriks @appleboy
Update markbates/goth library (#3533) (#3539)
8327300 
Signed-off-by: Lauris Bukšis-Haberkorns <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bwko Bwko Bwko approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Dropbox login | ERROR 500
6 participants
@lafriks @codecov-io @lunny @appleboy @Bwko @tboerger