Issue priority #4823

BetaCat0 · 2018-08-29T17:47:17Z

Priority updating api for issues (both web and api).
The build will fail due to this PR.

lafriks · 2018-08-29T20:59:59Z

I would prefer this to be labels based (like assigning label a priority) and priority in db for issue would be calculated as max from all labels when changing issue label(s)

lunny · 2018-08-30T06:02:55Z

@lafriks I think label priority and issue priority are different feature. We need both. I think label priority will not resolve all the things.

lunny · 2018-08-30T06:10:21Z

@BetaCat0 but I would like Issue priority not Feature priority. I think higest and lowest should be used in label priority. The issue priority could implement pin issue and unpin issue or you can update the priority value as what you want.

BetaCat0 · 2018-08-30T06:49:18Z

@lafriks I think label-based priority indicates the displaying sequence of a group of issues with a same label(like JIRA does) . Meanwhile a issue-based priority determine a fixed order in issues query. They don't conflict and they are somekind of two different features just like @lunny said.

BetaCat0 · 2018-08-30T06:49:39Z

@lunny working on it

lunny · 2018-08-30T14:02:20Z

models/issus_priority.go

-	HighestPriority
+	// PriorityDefault defines the default priority
+	PriorityDefault = 0
+	// PriorityDefault defines the pinned priority


error comment

routers/api/v1/api.go

models/issue.go

BetaCat0 · 2018-08-31T20:49:35Z

Build failed due to this PR

codecov-io · 2018-09-01T14:08:25Z

Codecov Report

Merging #4823 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4823   +/-   ##
=======================================
  Coverage   37.35%   37.35%           
=======================================
  Files         308      308           
  Lines       45567    45567           
=======================================
  Hits        17022    17022           
  Misses      26079    26079           
  Partials     2466     2466

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b6699...300b19e. Read the comment docs.

BetaCat0 · 2018-09-01T14:36:41Z

Ready for review 😀

lunny · 2018-09-02T14:06:02Z

Could you add some screenshot here?

BetaCat0 · 2018-09-03T05:16:48Z

BetaCat0 · 2018-09-03T05:24:24Z

And you can tap the PIN button to pin/unpin an issue

adelowo

You have files with issus_priority as part of their names ? Shouldn't that be issues_priority or issue_priority ?

models/issus_priority.go

adelowo · 2018-09-14T07:55:49Z

There are merge conflicts @BetaCat0

Signed-off-by: BetaCat0 [email protected]

UpdateIssuePriority is split into two APIs: PinIssue & UnpinIssue Signed-off-by: BetaCat0 [email protected]

Signed-off-by: BetaCat0 [email protected]

issue-unpin will auto trigger when issues close Signed-off-by: BetaCat0 [email protected]

stale · 2019-08-04T03:00:42Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

lunny · 2019-11-16T09:03:58Z

Please resolve the conflicts.

vtolstov · 2020-03-20T00:04:57Z

any chance to get this upstreamed/merged? @BetaCat0 @lafriks @lunny
or we have issue with more generic solution?

lafriks · 2020-03-20T21:55:52Z

I'm already working on label based priority implementation

codecov-commenter · 2020-06-07T06:51:13Z

Codecov Report

Merging #4823 into master will decrease coverage by 0.51%.
The diff coverage is 22.05%.

@@            Coverage Diff             @@
##           master    #4823      +/-   ##
==========================================
- Coverage   37.87%   37.35%   -0.52%     
==========================================
  Files         328      308      -20     
  Lines       48255    45567    -2688     
==========================================
- Hits        18276    17022    -1254     
+ Misses      27350    26079    -1271     
+ Partials     2629     2466     -163

Impacted Files	Coverage Δ
models/error.go	`32.48% <0.00%> (-0.94%)`	⬇️
modules/auth/repo_form.go	`39.00% <ø> (ø)`
routers/api/v1/repo/issue.go	`22.72% <0.00%> (-7.31%)`	⬇️
models/transaction.go	`40.00% <40.00%> (ø)`
routers/repo/issue.go	`32.33% <40.74%> (-4.25%)`	⬇️
models/issuse_priority.go	`50.00% <50.00%> (ø)`
models/issue.go	`48.68% <80.00%> (+1.09%)`	⬆️
routers/api/v1/api.go	`75.48% <100.00%> (+1.71%)`	⬆️
routers/routes/routes.go	`86.26% <100.00%> (+1.20%)`	⬆️
routers/api/v1/user/key.go	`8.33% <0.00%> (-43.65%)`	⬇️
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36402...300b19e. Read the comment docs.

AlexWayfer · 2021-09-09T18:30:54Z

@techknowlogick closed this 4 minutes ago

Why?

6543 · 2021-09-09T18:39:32Z

because: very stale; a better generic solution was proposed, ...

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2018

lafriks added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/changelog Adds the changelog for a new Gitea version labels Aug 29, 2018

lafriks added this to the 1.7.0 milestone Aug 29, 2018

BetaCat0 changed the title ~~Feature priority~~ Issue priority Aug 30, 2018

BetaCat0 changed the title ~~Issue priority~~ (WIP) Issue priority Aug 30, 2018

BetaCat0 changed the title ~~(WIP) Issue priority~~ WIP Issue priority Aug 30, 2018

BetaCat0 changed the title ~~WIP Issue priority~~ Issue priority Aug 30, 2018

lunny requested changes Aug 30, 2018

View reviewed changes

lunny requested changes Aug 31, 2018

View reviewed changes

models/issue.go Show resolved Hide resolved

adelowo suggested changes Sep 4, 2018

View reviewed changes

adelowo reviewed Sep 4, 2018

View reviewed changes

models/issus_priority.go Outdated Show resolved Hide resolved

BetaCat0 added 6 commits September 14, 2018 15:57

Priority updating api for issues (both web and api).

818f471

Signed-off-by: BetaCat0 [email protected]

recovery vendor.

87140e9

Signed-off-by: BetaCat0 [email protected]

remove update-issue-priority api temporarily

5177834

UpdateIssuePriority is split into two APIs: PinIssue & UnpinIssue Signed-off-by: BetaCat0 [email protected]

fix comments

b38e733

Signed-off-by: BetaCat0 [email protected]

fix issues & bug

8a021f2

issue-unpin will auto trigger when issues close Signed-off-by: BetaCat0 [email protected]

fix issue

52109e3

stale bot removed the issue/stale label May 25, 2019

techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019

stale bot added the issue/stale label Aug 4, 2019

lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2019

stale bot removed the issue/stale label Aug 4, 2019

techknowlogick modified the milestones: 1.10.0, 1.11.0 Sep 3, 2019

lunny modified the milestones: 1.11.0, 1.12.0 Dec 13, 2019

lunny modified the milestones: 1.12.0, 1.13.0 May 2, 2020

lunny modified the milestones: 1.13.0, 1.14.0 Sep 1, 2020

jolheiser mentioned this pull request Jan 18, 2021

Proposal: Handling of issue priority? #14377

Closed

6543 modified the milestones: 1.14.0, 1.15.0 Jan 18, 2021

techknowlogick modified the milestones: 1.15.0, 1.16.0 Jun 15, 2021

techknowlogick closed this Sep 9, 2021

techknowlogick removed this from the 1.16.0 milestone Sep 9, 2021

go-gitea locked and limited conversation to collaborators Oct 19, 2021

delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue priority #4823

Issue priority #4823

BetaCat0 commented Aug 29, 2018

lafriks commented Aug 29, 2018

lunny commented Aug 30, 2018

lunny commented Aug 30, 2018

BetaCat0 commented Aug 30, 2018 •

edited

Loading

BetaCat0 commented Aug 30, 2018

lunny Aug 30, 2018

BetaCat0 commented Aug 31, 2018

codecov-io commented Sep 1, 2018 •

edited

Loading

BetaCat0 commented Sep 1, 2018 •

edited

Loading

lunny commented Sep 2, 2018

BetaCat0 commented Sep 3, 2018

BetaCat0 commented Sep 3, 2018

adelowo left a comment •

edited

Loading

adelowo commented Sep 14, 2018

stale bot commented Aug 4, 2019

lunny commented Nov 16, 2019

vtolstov commented Mar 20, 2020

lafriks commented Mar 20, 2020

codecov-commenter commented Jun 7, 2020

AlexWayfer commented Sep 9, 2021

6543 commented Sep 9, 2021 •

edited

Loading

Issue priority #4823

Issue priority #4823

Conversation

BetaCat0 commented Aug 29, 2018

lafriks commented Aug 29, 2018

lunny commented Aug 30, 2018

lunny commented Aug 30, 2018

BetaCat0 commented Aug 30, 2018 • edited Loading

BetaCat0 commented Aug 30, 2018

lunny Aug 30, 2018

Choose a reason for hiding this comment

BetaCat0 commented Aug 31, 2018

codecov-io commented Sep 1, 2018 • edited Loading

Codecov Report

BetaCat0 commented Sep 1, 2018 • edited Loading

lunny commented Sep 2, 2018

BetaCat0 commented Sep 3, 2018

BetaCat0 commented Sep 3, 2018

adelowo left a comment • edited Loading

Choose a reason for hiding this comment

adelowo commented Sep 14, 2018

stale bot commented Aug 4, 2019

lunny commented Nov 16, 2019

vtolstov commented Mar 20, 2020

lafriks commented Mar 20, 2020

codecov-commenter commented Jun 7, 2020

Codecov Report

AlexWayfer commented Sep 9, 2021

6543 commented Sep 9, 2021 • edited Loading

BetaCat0 commented Aug 30, 2018 •

edited

Loading

codecov-io commented Sep 1, 2018 •

edited

Loading

BetaCat0 commented Sep 1, 2018 •

edited

Loading

adelowo left a comment •

edited

Loading

6543 commented Sep 9, 2021 •

edited

Loading