Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sqlite lock #5184

Merged
merged 4 commits into from
Oct 27, 2018
Merged

fix sqlite lock #5184

merged 4 commits into from
Oct 27, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 25, 2018

No description provided.

@lunny lunny added the type/bug label Oct 25, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 25, 2018
@codecov-io
Copy link

codecov-io commented Oct 25, 2018 •
edited
Loading

Codecov Report

Merging #5184 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5184      +/-   ##
==========================================
+ Coverage    37.5%   37.51%   +0.01%     
==========================================
  Files         309      309              
  Lines       45791    45798       +7     
==========================================
+ Hits        17172    17181       +9     
+ Misses      26158    26156       -2     
  Partials     2461     2461
Impacted Files Coverage Δ
models/issue.go 48.24% <33.33%> (+0.09%) ⬆️
models/repo.go 43.57% <66.66%> (+0.06%) ⬆️
models/issue_dependency.go 56.79% <83.33%> (+1.66%) ⬆️
models/repo_list.go 63.37% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c09df...86f930e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 26, 2018
sapk
sapk suggested changes Oct 26, 2018
View reviewed changes
models/issue_dependency.go Outdated Show resolved Hide resolved
models/repo.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member Author

lunny commented Oct 27, 2018

@sapk done.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2018
@lunny lunny merged commit 2b7c366 into go-gitea:master Oct 27, 2018
@lunny lunny deleted the lunny/fix_sqlite_lock2 branch October 27, 2018 14:45
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 7, 2019
@zeripath
Adjust media path to match go-gitea#5184
8b224e8 
Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @sapk @bkcsoft