-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add secret to all webhook's payload where it has been missing #5208
Conversation
* Updated dependency manager via `dep ensure -update code.gitea.io/sdk` * Gopkg.toml was not changed as sdk version is set to "master" * affects webhooks for: Delete, Fork, IssueComment, Release * also contains changes from go-gitea/go-sdk#125 and hence a swagger update Signed-off-by: Berengar W. Lehr <[email protected]> Resolves: #4732, #5173
But some changes are unrelated i.e. |
@lafriks why did you remove the backport/1.6 label? Is it a "it's a backport" or a "should be a backport" label? |
@HoffmannP just found I made a wrong label. backport/1.6 means should be backport to release 1.6 |
@HoffmannP this label should be added to PRs to master branch that needs to be backported to release/1.x branches |
@lafriks thank you for the clear up. I'm felling like I'm getting there |
I just tested the latest version |
@AuspeXeu Could you open an issue? Do you get any error log? |
@HoffmannP I added it to my initial issue #5173 I do not get any error logged unfortunately. |
dep ensure -update code.gitea.io/sdk
Signed-off-by: Berengar W. Lehr [email protected]
Resolves: #4732, #5173