Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit will reduce join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql (#5136) #5229

Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 31, 2018

  • This commit will reduce join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql

  • fix tests

backport from #5136

…earch, so that fix extra columns problem on mssql (go-gitea#5136)

* This commit will reduce join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql

* fix tests
@lunny lunny added the type/bug label Oct 31, 2018
@lunny
Copy link
Member Author

lunny commented Oct 31, 2018

and will fix #5148

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2018
@lunny lunny added this to the 1.6.0 milestone Oct 31, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2018
@techknowlogick techknowlogick merged commit 3786369 into go-gitea:release/v1.6 Nov 1, 2018
@lunny lunny deleted the lunny/fix_mssql_repo_search2 branch November 1, 2018 00:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants