Do not display the raw OpenID error in the UI #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no `WHITELIST_URIS` or `BLACKLIST_URIS` set in the openid section of the app.ini, it is possible that gitea can leak sensitive information about the local network through the error provided by the UI. This PR hides the error information and logs it. Fix go-gitea#4973 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
Jan 12, 2019
bkcsoft
added
the
lgtm/need 1
techknowlogick
added
topic/security
lunny
requested changes
Jan 12, 2019
Place error log within the `err != nil` branch.
Codecov Report
@@ Coverage Diff @@
## master #5705 +/- ##
=========================================
Coverage ? 37.76%
=========================================
Files ? 323
Lines ? 47596
Branches ? 0
=========================================
Hits ? 17974
Misses ? 27032
Partials ? 2590
Continue to review full report at Codecov.
|
lunny
approved these changes
Jan 12, 2019
bkcsoft
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 13, 2019
* Do not display the raw OpenID error in the UI If there are no `WHITELIST_URIS` or `BLACKLIST_URIS` set in the openid section of the app.ini, it is possible that gitea can leak sensitive information about the local network through the error provided by the UI. This PR hides the error information and logs it. Fix go-gitea#4973 Signed-off-by: Andrew Thornton <[email protected]> * Update auth_openid.go Place error log within the `err != nil` branch.
techknowlogick
pushed a commit
that referenced
this pull request
Jan 13, 2019
* Do not display the raw OpenID error in the UI If there are no `WHITELIST_URIS` or `BLACKLIST_URIS` set in the openid section of the app.ini, it is possible that gitea can leak sensitive information about the local network through the error provided by the UI. This PR hides the error information and logs it. Fix #4973 Signed-off-by: Andrew Thornton <[email protected]> * Update auth_openid.go Place error log within the `err != nil` branch.
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no
WHITELIST_URISorBLACKLIST_URISset in the openidsection of the app.ini, it is possible that Gitea can leak sensitive
information about the local network through the error provided by the
UI. This PR hides the error information and logs it.
Fix #4973
Signed-off-by: Andrew Thornton [email protected]