-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect value of REQUIRE_SIGNIN_VIEW #5901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
Is there an obvious test we can add?
I wonder if we can do some rationalisation of the :username/:repo routes. It might help prevent future situations like this if it was more explicit in the routes what had to be protected.
Codecov Report
@@ Coverage Diff @@
## master #5901 +/- ##
=======================================
Coverage 38.01% 38.01%
=======================================
Files 328 328
Lines 48337 48337
=======================================
Hits 18373 18373
Misses 27325 27325
Partials 2639 2639
Continue to review full report at Codecov.
|
@zeripath in the PR for "private orgs" I added logic that caught a lot of the missing routes that should be hidden. |
@techknowlogick you mean #1763 ? Should we just review and get that in instead? |
@zeripath yes, that's the PR. However I'm not sure it covers all cases, so we should get this PR in as well. |
Please backport to release v1.7 |
Fixes #5899