-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose issue stopwatch toggling via API #5970
Expose issue stopwatch toggling via API #5970
Conversation
4fc3634
to
488c40c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5970 +/- ##
=========================================
- Coverage 38.8% 38.71% -0.1%
=========================================
Files 330 330
Lines 48731 48853 +122
=========================================
+ Hits 18911 18912 +1
- Misses 27081 27201 +120
- Partials 2739 2740 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually like toggle method as you are kind of guessing state... I would prefer if API had start & stop methods
488c40c
to
2f9fb24
Compare
Done @lafriks. |
.. #4327 automatically stops the stopwatch but this PR will be useful in case there
is a need to programmatically toggle the stopwatch.
Fixes #5942