Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After deleting a repo on admin panel, UI should remember the last sort type #6033

Merged
merged 2 commits into from
Feb 11, 2019
Merged

After deleting a repo on admin panel, UI should remember the last sort type #6033

merged 2 commits into from
Feb 11, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 10, 2019

Fixes #3200

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 10, 2019
@lafriks lafriks added this to the 1.8.0 milestone Feb 10, 2019
@codecov-io
Copy link

codecov-io commented Feb 10, 2019 •
edited
Loading

Codecov Report

Merging #6033 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
+ Coverage   38.71%   38.72%   +0.01%     
==========================================
  Files         339      339              
  Lines       49013    49013              
==========================================
+ Hits        18976    18982       +6     
+ Misses      27291    27284       -7     
- Partials     2746     2747       +1
Impacted Files Coverage Δ
routers/admin/repos.go 0% <0%> (ø) ⬆️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71c28e...8837c71. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2019
@lafriks lafriks merged commit d0cb5aa into go-gitea:master Feb 11, 2019
@adelowo adelowo deleted the fix_3200 branch February 11, 2019 08:15
@adelowo adelowo mentioned this pull request Feb 11, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

After deleted repo on admin panel, UI should remember the last sort type.
5 participants
@adelowo @codecov-io @techknowlogick @lafriks @GiteaBot