Remove visitLinksForShortLinks features

[mrsdizzie]

The visitLinksForShortLinks feature would look inside of an <a> tag and run shortLinkProcessorFull on any text, which attempts to create links out of potential 'short links' like [[test]] [[link|example]] etc... This makes no sense becaused you can't have nested links within an existing <a> tag. Specifically, the html5 standard says <a> tags can't include interactive content if they contain the href attribute:

http://w3c.github.io/html/single-page.html#the-a-element

And also defines an element with a href attribute as interactive:

http://w3c.github.io/html/single-page.html#interactive-content

Therefore you can't really put a link inside of another link as this would try. In practice none of this should work anyway since browsers won't render it, it would probably be broken if they tried, and it is causing a bug (#4946). No current tests rely on this behavior either that I can see.

This removes the feature and also explicitly excludes the current visitNodeForShortLinks from looking in <a> tags.

---

Open to feedback if anybody knows of a legitimate use for this, but it appears to have been added as part of a much larger commit ( 535445c) without specific explanation as to the use case behind this. Thanks!

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@ad86b84). Click here to learn what that means.
The diff coverage is 80%.

@@           Coverage Diff            @@
##             master   #6257   +/-   ##
========================================
  Coverage          ?   38.8%           
========================================
  Files             ?     355           
  Lines             ?   50253           
  Branches          ?       0           
========================================
  Hits              ?   19502           
  Misses            ?   27922           
  Partials          ?    2829

Impacted Files	Coverage Δ
modules/markup/html.go	88.09% <80%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad86b84...00a11d9. Read the comment docs.

[zeripath]

I too am confused as to why this was originally there. Does this change break bold styling of the links etc?

[mrsdizzie]

It shouldn't since it only deals with the shortLinkProcessorFull function which doesn't handle any styling that I can see and returns a link when successful in any case. So all this change does is not run the following function:

gitea/modules/markup/html.go

Line 379 in ad86b84

func shortLinkProcessorFull(ctx *postProcessCtx, node *html.Node, noLink bool) {

... on the text inside of an existing link.

[mrsdizzie]

This should probably get a kind/bug tag as well -- when I was working on another branch without this fix I copied some test URLS which happened to included the example case from #4946 and it causes a 500 and none of the text to render at all

[techknowlogick]

@mrsdizzie thanks again for all the PRs you are sending. It is appreciated, and adding tests is especially appreciated.