-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent server 500 on compare branches with no common history #6555
Prevent server 500 on compare branches with no common history #6555
Conversation
I think 1.8 could do with this too. It's far too easy to get a 500 with this endpoint. |
@zeripath I am not 100% sure about a backport of this due to new translation being required (usually translations aren't backported), although I do like that this prevents 500s. If anyone else has feedback on being pro/anti backport please add it to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #6555 +/- ##
==========================================
- Coverage 40.36% 40.35% -0.01%
==========================================
Files 405 405
Lines 54255 54260 +5
==========================================
- Hits 21900 21899 -1
- Misses 29340 29347 +7
+ Partials 3015 3014 -1
Continue to review full report at Codecov.
|
I'm for backport as it is better to get error in English than get 500 page |
…ea#6555) * Prevent 500 if there is no common mergebase * Prevent creation of PR with no history
Backport done and merged. |
This PR prevents the compare branch from sending a server 500 if there is no common history between branches. Instead it presents a simple compare page.
Fixes #6527 and probably others.