Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macaron dependent on models/mail.go #6931

Merged
merged 3 commits into from
May 13, 2019
Merged

Remove macaron dependent on models/mail.go #6931

merged 3 commits into from
May 13, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 13, 2019

partially fix #6927

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 13, 2019
@lunny lunny mentioned this pull request May 13, 2019
Closed
@codecov-io
Copy link

codecov-io commented May 13, 2019 •
edited
Loading

Codecov Report

Merging #6931 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6931      +/-   ##
=========================================
- Coverage    41.4%   41.4%   -0.01%     
=========================================
  Files         441     441              
  Lines       59736   59736              
=========================================
- Hits        24736   24734       -2     
- Misses      31760   31763       +3     
+ Partials     3240    3239       -1
Impacted Files Coverage Δ
models/mail.go 26.49% <0%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b68fd...03d5e6c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2019
@zeripath
Copy link
Contributor

Hmm. My initial thought was that none of these methods belonged in models at all. I guess this works at removing the dependency.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 13, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@lafriks lafriks merged commit e63274e into go-gitea:master May 13, 2019
@lunny lunny deleted the lunny/remove_depend_macaron branch May 14, 2019 00:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

models should not depend on macaron
6 participants
@lunny @codecov-io @zeripath @lafriks @GiteaBot @techknowlogick