Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macaron dependent on modules/log #6933

Merged
merged 3 commits into from
May 14, 2019
Merged

Remove macaron dependent on modules/log #6933

merged 3 commits into from
May 14, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 13, 2019

partially fix #6927

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 13, 2019
zeripath
zeripath reviewed May 13, 2019
View reviewed changes
routers/routes/routes.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2019
@codecov-io
Copy link

codecov-io commented May 13, 2019 •
edited
Loading

Codecov Report

Merging #6933 into master will increase coverage by <.01%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6933      +/-   ##
=========================================
+ Coverage    41.4%   41.4%   +<.01%     
=========================================
  Files         441     441              
  Lines       59736   59733       -3     
=========================================
+ Hits        24732   24733       +1     
+ Misses      31765   31760       -5     
- Partials     3239    3240       +1
Impacted Files Coverage Δ
routers/routes/routes.go 82.68% <100%> (+0.28%) ⬆️
modules/log/colors_router.go 83.33% <83.33%> (ø)
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
modules/log/log.go 71.42% <0%> (+2.52%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3957b40...2a36272. Read the comment docs.

@lafriks lafriks added this to the 1.9.0 milestone May 13, 2019
@lunny
Copy link
Member Author

lunny commented May 14, 2019

@zeripath done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2019
@techknowlogick techknowlogick merged commit 6123840 into go-gitea:master May 14, 2019
@lunny lunny deleted the lunny/remove_log_depent_macaron branch November 18, 2020 04:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

models should not depend on macaron
7 participants
@lunny @codecov-io @mrsdizzie @zeripath @techknowlogick @lafriks @GiteaBot