Fix index produces problem when issues/pulls deleted #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetaCat0
approved these changes
May 17, 2019
GiteaBot
added
the
lgtm/need 1
|
Does xorm support to use expressions on inserts? Most correct solution would be to use |
|
@lafriks xorm support that but mysql and maybe other databases don't support. |
|
Hmm we're going to have problems with this if we have a very active repository. This is however a lot better than our current implementation. |
zeripath
approved these changes
May 17, 2019
GiteaBot
added
lgtm/done
|
Make L-G-T-M work |
|
MySQL, postgres and mssql support that, don't know about sqlite tho, need to test that :) |
|
It should be, see http://www.sqlitetutorial.net/sqlite-functions/sqlite-coalesce/ |
7 tasks
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* fix index produces problem when issues/pulls deleted * fix tests * fix tests * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an issue of a repo has been deleted( we haven't implement that on gitea currently) or the number counting failed on repository, creating issue/pull will always failed. This PR will fix that problem and when both two issue are created then retry will resolve the problem. This is not the final resolution, but it will not block user creating issue.