Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to return blob on submodule #6996

Merged

Conversation

zeripath
Copy link
Contributor

Fixes #6945 by not attempting to return a blob from a submodule.

@zeripath zeripath added this to the 1.9.0 milestone May 19, 2019
@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #6996 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6996      +/-   ##
=========================================
+ Coverage   41.49%   41.5%   +0.01%     
=========================================
  Files         440     440              
  Lines       59453   59453              
=========================================
+ Hits        24670   24676       +6     
+ Misses      31563   31558       -5     
+ Partials     3220    3219       -1
Impacted Files Coverage Δ
modules/git/tree_blob.go 82.92% <100%> (ø) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bfd00...0d0c8f8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2019
@lunny
Copy link
Member

lunny commented May 20, 2019

@zeripath tests will be better.

@zeripath
Copy link
Contributor Author

I really don't fancy trying to add tests for the compare endpoint. That would turn this one-line fix into a staggering behemoth, and I'd find and have to fix all of the rest of the bugs in compare.

If I start down that path I'll end up rewriting the whole damned diff architecture.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2019
@zeripath zeripath merged commit 0d69dfb into go-gitea:master May 21, 2019
@zeripath zeripath deleted the fix-#6945-ensure-repo-box-is-set-properly branch May 22, 2019 18:01
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error opening Pull requests with changed git submodules
6 participants