-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to return blob on submodule #6996
Do not attempt to return blob on submodule #6996
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6996 +/- ##
=========================================
+ Coverage 41.49% 41.5% +0.01%
=========================================
Files 440 440
Lines 59453 59453
=========================================
+ Hits 24670 24676 +6
+ Misses 31563 31558 -5
+ Partials 3220 3219 -1
Continue to review full report at Codecov.
|
@zeripath tests will be better. |
I really don't fancy trying to add tests for the compare endpoint. That would turn this one-line fix into a staggering behemoth, and I'd find and have to fix all of the rest of the bugs in compare. If I start down that path I'll end up rewriting the whole damned diff architecture. |
Fixes #6945 by not attempting to return a blob from a submodule.