Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UpdateRepoIndex api to include watchers #7012

Merged
merged 3 commits into from
May 23, 2019
Merged

Change UpdateRepoIndex api to include watchers #7012

merged 3 commits into from
May 23, 2019

Conversation

zeripath
Copy link
Contributor

This PR changes the UpdateRepoIndex api to include any number of error channel watchers.

@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #7012 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7012      +/-   ##
=========================================
+ Coverage    41.5%   41.5%   +<.01%     
=========================================
  Files         440     440              
  Lines       59453   59457       +4     
=========================================
+ Hits        24675   24677       +2     
- Misses      31558   31560       +2     
  Partials     3220    3220
Impacted Files Coverage Δ
models/repo_indexer.go 67.08% <90%> (+0.55%) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb53ac...4f57a38. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2019
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 21, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 21, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2019
@lunny
Copy link
Member

lunny commented May 22, 2019

It seems UpdateRepoIndexer was not be really invoked?

@lafriks
Copy link
Member

lafriks commented May 22, 2019

@lunny It is called in multiple places, other places just does not need to be changed as watchers are optional arguments

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2019
@zeripath zeripath merged commit 54bd63c into go-gitea:master May 23, 2019
@zeripath zeripath deleted the repo-index-channel-api branch May 23, 2019 16:00
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@zeripath @jeffliu27
Change UpdateRepoIndex api to include watchers (go-gitea#7012)
4a5d8d3 
* Change UpdateRepoIndex api to include watchers

* Add timeout
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @lunny @lafriks @GiteaBot