Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSH server on Windows when running as service #736

Merged
merged 5 commits into from
Jan 25, 2017
Merged

Fix SSH server on Windows when running as service #736

merged 5 commits into from
Jan 25, 2017

Conversation

andreynering
Copy link
Contributor

Closes #680

@andreynering andreynering added this to the 1.1.0 milestone Jan 23, 2017
@lunny
Copy link
Member

lunny commented Jan 25, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2017
@makhov
Copy link
Contributor

makhov commented Jan 25, 2017

Why we need to copy minwinsvc from vendor to project?

@andreynering
Copy link
Contributor Author

@maklov See kardianos/minwinsvc#3

I don't know if it will be accepted, because it's a Gitea-specific trick.

I talked with @tboerger on Gitter and we decided to copy it since it's a small lib.

@makhov
Copy link
Contributor

makhov commented Jan 25, 2017

OK. LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2017
@andreynering andreynering merged commit e7c3be5 into go-gitea:master Jan 25, 2017
@andreynering andreynering deleted the fix-windows-ssh branch January 25, 2017 16:20
@andreynering andreynering mentioned this pull request Mar 7, 2017
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

SSH server does not work when running as windows service.
4 participants
@andreynering @lunny @makhov @tboerger