Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

err_admin_name_pattern_not_allowed String Clarification #9731

Merged
merged 4 commits into from
Jan 15, 2020
Merged

err_admin_name_pattern_not_allowed String Clarification #9731

merged 4 commits into from
Jan 15, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 12, 2020

As per title, this will close #9730.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2020
@bagasme @zeripath
Apply suggestion from @zeripath
eb8c0a9 
Context: username that provided as admin

Co-Authored-By: zeripath <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #9731 into master will increase coverage by 0.04%.
The diff coverage is 67.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9731      +/-   ##
==========================================
+ Coverage   42.27%   42.31%   +0.04%     
==========================================
  Files         597      599       +2     
  Lines       78257    78330      +73     
==========================================
+ Hits        33082    33148      +66     
- Misses      41124    41126       +2     
- Partials     4051     4056       +5
Impacted Files Coverage Δ
models/repo_branch.go 100% <ø> (+49.56%) ⬆️
modules/auth/admin.go 0% <ø> (ø) ⬆️
modules/migrations/base/pullrequest.go 0% <ø> (ø) ⬆️
models/migrations/migrations.go 1.3% <ø> (ø) ⬆️
models/lfs.go 17.27% <0%> (ø) ⬆️
modules/migrations/gitea.go 7.91% <0%> (-0.05%) ⬇️
routers/admin/users.go 28.69% <0%> (-0.13%) ⬇️
models/migrations/v121.go 0% <0%> (ø)
routers/admin/orgs.go 0% <0%> (ø) ⬆️
routers/api/v1/admin/org.go 46.73% <0%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8c0a9...e363582. Read the comment docs.

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 15, 2020
@sapk sapk merged commit 3f1e062 into go-gitea:master Jan 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@guillep2k guillep2k guillep2k approved these changes

@sapk sapk sapk approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

err_admin_name_pattern_not_allowed Source String Incorrect
8 participants
@bagasme @codecov-io @zeripath @sapk @guillep2k @6543 @techknowlogick @GiteaBot