Don't convert ellipsis in markdown

[jolheiser]

Fixes #9904

[codecov-io]

Codecov Report

Merging #9905 into master will decrease coverage by 0.01%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #9905      +/-   ##
==========================================
- Coverage    42.3%   42.28%   -0.02%     
==========================================
  Files         607      608       +1     
  Lines       79353    79393      +40     
==========================================
+ Hits        33571    33574       +3     
- Misses      41640    41677      +37     
  Partials     4142     4142

Impacted Files	Coverage Δ
services/gitdiff/gitdiff.go	66.36% <0%> (ø)	⬆️
services/pull/commit_status.go	5.19% <0%> (-2.97%)	⬇️
routers/repo/pull.go	28.67% <0%> (-0.07%)	⬇️
models/commit_status.go	64.13% <100%> (-2.2%)	⬇️
routers/api/v1/repo/status.go	44.57% <50%> (ø)	⬆️
modules/structs/commit_status.go	54.54% <54.54%> (ø)
services/pull/check.go	56.64% <0%> (+2.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a4798...d9d1fe8. Read the comment docs.

[WGH-]

Is it the proper fix, though? I mean the bug is not in the ellipsis convertion per se, but rather that ellipsises are converted inside autolinked URLs as well.

Maybe that's the only thing we can do for the time being, but I think this warrants creating an upstream bug as well.

[zeripath]

It's not upstream's fault - it's ours. Really we should run this filter after we've detected all the urls - but we do that outside of the markdown renderer.

What we need to do is do the link detection from within markdown and only run our link detection on html files.

[sapk]

@jolheiser Please send backport.