-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move CSS build to webpack #9983
Conversation
eba151b
to
3278869
Compare
b6e9644
to
2d20135
Compare
Partially unrelated, but I reworked the "Building Gitea" in CONTRIBUTING.md to just link to the hacking guide as info in it was partially outdated. |
Codecov Report
@@ Coverage Diff @@
## master #9983 +/- ##
==========================================
- Coverage 42.25% 42.25% -0.01%
==========================================
Files 610 610
Lines 80387 80387
==========================================
- Hits 33966 33964 -2
- Misses 42240 42243 +3
+ Partials 4181 4180 -1
Continue to review full report at Codecov.
|
af80aec
to
907cafd
Compare
Rebased and squashed. |
@silverwind is there any way we can stop having to rebuild fomantic and the webpack every time we do make build? My machine is FAST but it's taking a considerable amount of time to test one line changes because of this. (We could also do with something similar for go generate - it's a real shame that bindata is regenerated despite no changes - I might take a look at that...) |
Ah, I think I found something that triggers useless fomantic rebuilds, testing.. |
#9999 for possible workaround. Regarding |
I was thinking of doing it in the generate functions themselves... They're the thing that is doing the work. |
907cafd
to
d4cc116
Compare
@zeripath possible, but I think Rebased here and also added a |
- added new 'make webpack' target - deprecated 'make js' and 'make css' - extend webpack config to load the less files - updated docs I had to rename the source file of `arc-green.less` to avoid generating a useless JS entrypoint via webpack-fix-style-only-entries which would not work with different source/destination filenames. I hear that there should be cleaner solutions possible once we upgrade to Webpack 5.
7c2540b
to
cbceca4
Compare
Rebased |
I had to rename the source file of
arc-green.less
to avoid generating a useless JS entrypoint via webpack-fix-style-only-entries which would not work with different source/destination filenames. I hear that there should be cleaner solutions possible once we upgrade to Webpack 5.