Add Strs helper for Go 1.6 cgo pointer passing rules. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Str helper to panic on invalid input rather than os.Exit. A panic will help identify where the problem is during development, and in general, libraries should avoid os.Exit in favor of panic. Use plain panic, since log.Panicln results in panic text printed twice, which is unhelpful. It's also less imports. Remove //glow:rmspace to preserve whitespace. It's not needed in this small hand-written .go file.
This new helper creates C strings in the C heap using malloc, unlike the normal Str helper that uses Go memory. It's possible to pass it to cgo, for example, for gl.ShaderSource. This is intended usage: csources, free := gl.Strs(source) // source string ends with "\x00" gl.ShaderSource(shader, 1, csources, nil) free() Or for multiple parameters: csources, free := gl.Strs(sources...) // all strings end with "\x00" gl.ShaderSource(shader, len(sources), csources, nil) free() It returns a free func that must be called once the string is no longer needed to free memory. Pair programmed implementation of Strs with @slimsag. Fixes #66. Needed for go-gl/gl#31.
|
LGTM |
dmitshur
added a commit
to go-gl/gl
that referenced
this pull request
Feb 20, 2016
This new helper creates C strings in the C heap using malloc, unlike the normal Str helper that uses Go memory. It's possible to pass it to cgo, for example, for gl.ShaderSource. This is intended usage: csources, free := gl.Strs(source) // source string ends with "\x00" gl.ShaderSource(shader, 1, csources, nil) free() Or for multiple parameters: csources, free := gl.Strs(sources...) // all strings end with "\x00" gl.ShaderSource(shader, len(sources), csources, nil) free() It returns a free func that must be called once the string is no longer needed to free memory. Pair programmed implementation of Strs with @slimsag. Fixes #31. Generated using changes in go-gl/glow#69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new helper creates C strings in the C heap using
malloc, unlikethe normal
Strhelper that uses Go memory.It's possible to pass it to cgo, for example, for
gl.ShaderSource. Thisis intended usage:
Or for multiple parameters:
It returns a free func that must be called once the string is no longer
needed to free memory.
Pair programmed implementation of
Strswith @slimsag.Fixes #66. Needed for go-gl/gl#31.