Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: make gremlins work on packages #120

Merged
merged 9 commits into from
Aug 10, 2022

Conversation

k3rn31
Copy link
Member

@k3rn31 k3rn31 commented Aug 9, 2022

In this PR:

Now gremlins can work in sub packages. It can be used passing the package as argument or calling it without arguments in the current folder:

gremlins unleash pkg/myPackage
cd pkg/pyPackage
gremlins unleash

@k3rn31 k3rn31 added the c/feature Category: An issue or PR related to a new feature label Aug 9, 2022
@k3rn31 k3rn31 added this to the v0.3.0 milestone Aug 9, 2022
@k3rn31 k3rn31 requested a review from giose86 August 9, 2022 09:21
@k3rn31 k3rn31 linked an issue Aug 9, 2022 that may be closed by this pull request
@pull-request-size pull-request-size bot added the s/L Size: Denotes a Pull Request that changes 100-499 lines label Aug 9, 2022
@k3rn31 k3rn31 force-pushed the 50-make-gremlins-work-in-packages branch from a16f561 to 9fa59c5 Compare August 9, 2022 09:23
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #120 (4e27c98) into main (fd478af) will increase coverage by 0.37%.
The diff coverage is 92.47%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   84.36%   84.74%   +0.37%     
==========================================
  Files          15       16       +1     
  Lines        1049     1101      +52     
==========================================
+ Hits          885      933      +48     
- Misses        135      139       +4     
  Partials       29       29              
Flag Coverage Δ
unittests 84.74% <92.47%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/unleash.go 51.02% <28.57%> (-1.04%) ⬇️
pkg/coverage/coverage.go 94.50% <77.77%> (-2.75%) ⬇️
configuration/configuration.go 96.66% <100.00%> (+0.77%) ⬆️
internal/gomodule/gomodule.go 100.00% <100.00%> (ø)
pkg/mutator/mutator.go 91.20% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k3rn31 k3rn31 self-assigned this Aug 9, 2022
giose86
giose86 previously approved these changes Aug 9, 2022
Also fix the configuration loading order.
@pull-request-size pull-request-size bot added s/XL Size: Denotes a PR that changes 500-999 lines and removed s/L Size: Denotes a Pull Request that changes 100-499 lines labels Aug 9, 2022
@k3rn31 k3rn31 requested a review from giose86 August 9, 2022 14:20
@k3rn31 k3rn31 force-pushed the 50-make-gremlins-work-in-packages branch from 98a1e72 to 4e27c98 Compare August 9, 2022 16:33
@k3rn31 k3rn31 requested a review from giorgiaroccetti August 9, 2022 16:34
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2022

Code Climate has analyzed commit 4e27c98 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.4% (70% is the threshold).

This pull request will bring the total coverage in the repository to 87.3% (0.2% change).

View more on Code Climate.

@k3rn31 k3rn31 merged commit 57aeb87 into main Aug 10, 2022
@k3rn31 k3rn31 deleted the 50-make-gremlins-work-in-packages branch August 10, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/feature Category: An issue or PR related to a new feature s/XL Size: Denotes a PR that changes 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gremlins work in packages
2 participants