-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutant: add INVERT_LOOPCTRL mutation #159
mutant: add INVERT_LOOPCTRL mutation #159
Conversation
17f6021
to
34cc6c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 88.03% 88.07% +0.04%
==========================================
Files 18 18
Lines 1295 1300 +5
==========================================
+ Hits 1140 1145 +5
Misses 128 128
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hello @alessio-perugini, thanks for you PR. I enabled the CI for you. |
@k3rn31 thank you! I run a simple test when the mutant generates an infinite loop and the result is a |
@alessio-perugini I'd say it is to be expected in this kind of mutation. It is showing a brittle test case :) As soon as you mark it as non draft we'll proceed with the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR. Everything looks good.
Since this kind of mutation can produce lots of unbound loops and, consequently, timeouts, it is maybe better to keep it disabled by default.
Could you please fix that and update the documentation accordingly?
Also, since every mutation increases testing times, we decided to keep all the new mutations disabled by default, leaving to the user the decision to enable them on the basis of project necessities. In the future we'll make some statistics to craft a better core set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, I'm going to merge this.
Proposed changes
Implement #136 invert loop break/continue
Types of changes
Checklist
make all
)Further comments
I've added the loop control support. I'm not sure if the fixtures are good enough.
I was wondering what will happen when changing the control results in an infinite loop?