brio-gen: follow Go standard for generated files #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix brio-gen to produce files with the standard Go header for generated files. See https://golang.org/s/generatedcode
Fix call to brio-gen command from go:generate to use the local copy of brio-gen (using "go run") instead of an installed binary that may be outdated.
Files are now generated with the standard Go header for generated files. See https://golang.org/s/generatedcode cd hbook; go generate -run=brio-gen hbook.go
|
@sbinet I have some further improvement ideas for brio-gen, but I'm waiting for this PR to be merged as it impacts all generated files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One standard exists for Go generated files: https://golang.org/s/generatedcode
This pull request:
.gitignorefor files produced by brio-gen testsbrio-gento follow the standard for the files it producesgo:generatecommands inhbook/hbook.goto runbrio-genfrom the source (do not require an installed binary)hbook:go generate -run=brio-gen hbook.go