Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/form: support repeated filed map from path etc. #1512

Closed
wants to merge 3 commits into from

Conversation

Cluas
Copy link
Contributor

@Cluas Cluas commented Sep 24, 2021

Description (what this PR does / why we need it):

#1193

Other special notes for reviewer:

Now there is no compulsion to use the same legal separator, which means that the user can use the format a b,c|d\te, which will also be legally parsed as []string{"a", "b", "c", "d", "e"}, I'm not sure if this is good practice, maybe we can restrict it to a single legal separator.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #1512 (da0625e) into main (7cc6565) will increase coverage by 0.23%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   68.56%   68.80%   +0.23%     
==========================================
  Files          67       67              
  Lines        3089     3119      +30     
==========================================
+ Hits         2118     2146      +28     
  Misses        791      791              
- Partials      180      182       +2     
Impacted Files Coverage Δ
encoding/form/form.go 67.56% <0.00%> (ø)
encoding/form/proto_decode.go 27.11% <86.66%> (+9.16%) ⬆️
transport/http/binding/bind.go 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc6565...da0625e. Read the comment docs.

@Cluas
Copy link
Contributor Author

Cluas commented Sep 26, 2021

Considering the complexity, it is recommended to first pass the array via parameter instead of path, something like id=1&id=2, to temporarily turn off this PR.

@Cluas Cluas closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants