Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate test codes. #3187

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Feb 3, 2024

Description (what this PR does / why we need it):

有两个 test case 重了,我给删除了。

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (f566bdc) to head (40f2c0d).

❗ Current head 40f2c0d differs from pull request most recent head bcb8006. Consider uploading reports for the commit bcb8006 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
+ Coverage   84.62%   84.72%   +0.10%     
==========================================
  Files          88       88              
  Lines        3993     3993              
==========================================
+ Hits         3379     3383       +4     
+ Misses        440      438       -2     
+ Partials      174      172       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shenqidebaozi
shenqidebaozi previously approved these changes Mar 11, 2024
@dosubot dosubot bot added the LGTM label Mar 11, 2024
@demoManito
Copy link
Member

need to resolve the code conflict

@kvii
Copy link
Contributor Author

kvii commented Mar 13, 2024

@demoManito Conflict solved.

@daemon365 daemon365 merged commit 63344c3 into go-kratos:main Mar 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants