Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buf config for protoc-gen-go-errors #3403

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

akoserwal
Copy link
Contributor

Description (what this PR does / why we need it):

  • Is buf.build/go-kratos currently owned by go-kratos team?
  • I raised PR for protoc-gen-go-errors, it can add for protoc-gen-go-http

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 21, 2024
- remote: buf.build/protocolbuffers/go:v1.33.0
out: .
opt:
- paths=source_relative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a blank line here

@akoserwal
Copy link
Contributor Author

Require a Github action for pushing to buf registry, Generate a buf token which can be configured to the secrets

on:
  push:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: bufbuild/buf-setup-action@v1
      - uses: bufbuild/buf-lint-action@v1
        with:
          input: "api"
      - uses: bufbuild/buf-breaking-action@v1
        with:
          input: "api"
          against: "https://github.com/${GITHUB_REPOSITORY}.git#branch=main,ref=HEAD~1"
      - uses: bufbuild/buf-push-action@v1
        with:
          input: "api"
          buf_token: ${{ secrets.BUF_TOKEN }}```

@shenqidebaozi
Copy link
Member

shenqidebaozi commented Aug 26, 2024

Require a Github action for pushing to buf registry, Generate a buf token which can be configured to the secrets

@akoserwal Do I have to complete this operation? Can you operate it

We can discuss separately and merge the current PRs first

@dosubot dosubot bot added the LGTM label Aug 26, 2024
@akoserwal
Copy link
Contributor Author

akoserwal commented Aug 26, 2024

Require a Github action for pushing to buf registry, Generate a buf token which can be configured to the secrets

@akoserwal Do I have to complete this operation? Can you operate it

We can discuss separately and merge the current PRs first

@shenqidebaozi

  • I would suggest creating an org/team on buf registry and generating a secret token

https://buf.build/docs/bsr/authentication#create-a-token

  • Which can be configured as BUF_TOKEN github secrets
  • You can add the github actions with code pasted above

@shenqidebaozi shenqidebaozi enabled auto-merge (squash) August 28, 2024 08:36
@shenqidebaozi shenqidebaozi disabled auto-merge August 29, 2024 01:56
@shenqidebaozi shenqidebaozi merged commit da73565 into go-kratos:main Aug 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants