Fix race conditions #101
Merged
Fix race conditions #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready to go now 😸 |
|
@liggitt - Anything I can do to help move this forward? |
liggitt
reviewed
Feb 2, 2017
conn.go
Outdated
| @@ -333,8 +344,8 @@ func (l *Conn) processMessages() { | |||
| for messageID, msgCtx := range l.messageContexts { | |||
| // If we are closing due to an error, inform anyone who | |||
| // is waiting about the error. | |||
| if l.isClosing && l.closeErr != nil { | |||
| msgCtx.sendResponse(&PacketResponse{Error: l.closeErr}) | |||
| if l.isClosing() && l.closeErr.Load().(error) != nil { | |||
There was a problem hiding this comment.
what does l.closeErr.Load().(error) do if no error was stored in closeErr?
There was a problem hiding this comment.
pretty sure it'll panic... do an uncast nil check here and cast inside the block?
There was a problem hiding this comment.
Yeah, good catch here - this was supposed to be an uncast check. Fixed!
liggitt
reviewed
Feb 2, 2017
|
|
||
| // setClosing sets the closing value to true | ||
| func (l *Conn) setClosing() { | ||
| atomic.AddUint32(&l.closeCount, 1) |
|
squash the two test commits. just the one question about the |
adunham-stripe
force-pushed
the
adunham/fix-race
branch
from
e1f6684 to
668db80
Compare
|
Squashed, and the cast is fixed. |
|
thanks for the fix |
|
Awesome! Thanks a bunch for merging 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some various data races, mostly around the
isClosing/closeErrfields in theConnstruct. I've taken a similar route as #74, but with full support for older versions of Go that don't support thesync/atomic.Valuestruct.