fix dn parsing without attr or value #119
Conversation
|
LGTM, squash before merge |
|
@liggitt done |
| @@ -143,6 +143,9 @@ func ParseDN(str string) (*DN, error) { | |||
| } | |||
| } else if char == ',' || char == '+' { | |||
| // We're done with this RDN or value, push it | |||
| if len(attribute.Type) == 0 { | |||
| return nil, errors.New("incomplete type, value pair") | |||
There was a problem hiding this comment.
just had a thought... should we include stringFromBuffer() in the error to aid debugging the bad attribute? or if we don't want to allow injecting arbitrary values into the message, at least include the position?
There was a problem hiding this comment.
I guess we didn't include the bad attribute in the "DN ended with incomplete type, value pair" message
There was a problem hiding this comment.
do we also need to check for len(attribute.Type) == 0 in the if char == '=' block, to catch =foo,DC=example,DC=com?
There was a problem hiding this comment.
That's caught here or with the "DN ended with incomplete type, value pair" error, adding
"=test,DC=example,DC=com": "incomplete type, value pair", in dn_test.go:TestErrorDNParsing() passes.
There was a problem hiding this comment.
added as test and squashed
|
thanks, looks like it needs a rebase on top of your other PR |
|
done... |
* upstream/master: fix dn parsing without attr or value (go-ldap#119) fix unbalanced parenthesis panic when compiling filter
fixes #114