Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DIGEST-MD5 bind support #230

Merged
merged 7 commits into from
Feb 5, 2020
Merged

Add DIGEST-MD5 bind support #230

merged 7 commits into from
Feb 5, 2020

Conversation

microo8
Copy link
Contributor

@microo8 microo8 commented Sep 9, 2019

It's not the most elegant code, but it works for me :)

johnweldon
johnweldon reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
Would you be willing to refactor this per the recent PR that also added other Bind mechanisms, and unified some of the internal flow?
Additionally, some tests/examples/documentation would be welcome too.

@microo8
Copy link
Contributor Author

microo8 commented Feb 3, 2020

Changed the DigestMD5BindRequest.appendTo function to satisfy the request interface.
Also I've added some doc comments.

johnweldon
johnweldon requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a minor change that needs to be reverted.

go.mod Outdated
@@ -1,5 +1,8 @@
module github.com/go-ldap/ldap
module github.com/microo8/ldap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted

johnweldon
johnweldon approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @microo8
LGTM

@johnweldon johnweldon merged commit 0e14253 into go-ldap:master Feb 5, 2020
@johnweldon johnweldon mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnweldon johnweldon johnweldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microo8 @johnweldon