-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export AddRequest Struct variables in add.go #60
Conversation
wrote get methods to struct AddRequest, as the struct variables are not global, and if I want to compare two add requests before populating it.
Changed get method names
Added a SetDN method to AddRequest. A usecase is, the result returned from AD is of uppercase realm for DN, and if a comparison needs to be done against an openldap result, it has to be converted to something similar in lowercase. This method makes it easy, as the SetDN sets the value to the pointer. Eg: ```i.SetDN(r.ReplaceAllStringFunc(input, func(m string) string { return strings.ToLower(m) }))```
All the request structs except |
That's so kind of you, Thank you. I was wondering about modifying DN of the addrequest. One issue I faced was while comparing AD and LDAP add requests, where AD was returning realms like |
that seems more like a normalization issue, not specific to add requests |
Gotcha, Thank you. |
@liggitt Would you prefer to keep the get methods, or keep the struct fields exported like
|
yeah, I would just export the fields |
Thank you |
I was wondering, if it would be fine to expose the Attribute struct's fields
in |
I think it's ok to expose those, though I'd like to rename them to match the LDAP names before exposing them, so |
Hi @liggitt I was wondering if this can be merged, as we are using a forked one for our project temporarily. |
Thank you @liggitt |
wrote get methods to struct AddRequest in add.go, as the struct variables are not global, and it would be easy if an add request wants to be compared with another one before populating it.